WitheredGryphon
Member
- Joined
- Sep 21, 2020
- Messages
- 81
- Reputation score
- 41
Aye, this is an old one.The modders made way too many checks for this or that situation, with new skills becoming conditionally available; this 'error' prompts the succubus to use a default move. 300 is way too high IMO. There are a couple annoying others (missing dialogues reports, etc).
Ref: start of the loop -> # 発動不可なスキルの場合、発動可能なものが出るまで選び直し
The mods were tailored for fully leveled (50-80+) succubi. You'd get this more often with vanilla LvL 5 girls.
Anwyay you're not supposed to play in DEBUG mode (I always do but...). I'll triple-check we share no file turning it on; oc we don't want new players running into that. Write $DEBUG = false at the end of your very last rb file, abc order, and these won't bother you again.
Your example is relatively easy:
PS: I'd suggest you copy all of skilltext to notepad++, and mass replace (normal text) \m, \w, \y to our friendly \ɱ, \ɯ, \ȳ. If anything goes south (it won't!) we can always revert them.But it can become much, much more complicated; and case-by-case takes time. We don't want that.Ruby:when 81 #キッス ##### this was abbreviated ###### held = "" if myself.holding? held = " shifted position and\ɱ\n" #backslash not needed in \ɱ end action = premess + held + "、exchanged a kiss with #{targetname}!"
In any case the return is line 6662 and not earlier. You could ignore newlines completely in the file, and make your real lines here. As another temporary measure, you could decide an arbitrary letters count, and insert a \n in the nearest whitespace should action.length exceed the threshold. In short: don't worry too much.
If the battlers' names are a concern(they are!), you can use (lines 19-21):
myname = $names_DB.to_eng(myself.name)
username = $names_DB.to_eng(user.name)
skill_name = skill.UK_name#.split(/\//)[0]
Not too efficient, but that'll work until I finally implement UK_name for any and all battlers. If even necessary.
I also noticed the default font was a crappy one (for Latin characters). We have:
$default_font = ["メイリオ","MS Pゴシック"]
I'll make MS Pゴシック the default one if you don't mind. It's not that great, but looks way better. Was SQ's font too.
That will change the battle display a lot. So feel free to adjust the sizes if necessary. They say, bigger is better; and for once, my eyes agree.Ruby:$default_font = ["MS Pゴシック"] $default_size = 16 $default_size_mini = 13 $default_size_s_mini = 11
PPS: the code ain't trash!It's called vintage!
(If there's weird text formatting in this reply, ignore it. Posting on ULMF from mobile is actual garbage).
Let me clarify some things. First, I have already copied skill text and batch replaced it as mentioned. There is stuff other than SkillText which use the \w, \m, etc.
If we're going to make a second line for the response regardless then I'm just going to like break manually. Having an arbitrary character word wrap is more obnoxious to make and won't look nearly as good since the first line's spacing will be all over the place every throughout the battle. So again, if we're fine with having this number of lines like in the example already, then I'll just leave it as is.
I'm still not clear what's actually resulting in the debug message proc'ing though? What exactly is "300"? Is that the number of checks that have occurred? This happened with the very first succubus when I was testing the bedroom scene. Defaulting to a move sounds like a bad thing. Is this something we need to look into?
I'll look into the font once I'm back at my computer, but some screenshots of examples with that font would be nice to have an idea since I won't be back for a while.
Really appreciate your work on this, i've waited for so long. That said, downloading new programs is pretty daunting though i suppose theres no way around it since the game's code is trash.
Like I mentioned, this is for testing purposes only and may not be reflective of the final installation process. Doing this makes sure testers have the same version as us. That way we aren't spending time debugging outdated versions of the mod or game.